Improve prometheus error handling (#108)

This commit is contained in:
Stephen Marshall
2018-06-04 15:31:03 +01:00
committed by Rob Parker
parent 2af6953b2b
commit 5d0a87ae0a
3 changed files with 27 additions and 9 deletions

View File

@@ -27,10 +27,11 @@ func TestDescribe(t *testing.T) {
teardownTestCase := setupTestCase(false)
defer teardownTestCase()
log := getTestLogger()
ch := make(chan *prometheus.Desc)
go func() {
exporter := newExporter("qmName")
exporter := newExporter("qmName", log)
exporter.Describe(ch)
}()
@@ -39,7 +40,7 @@ func TestDescribe(t *testing.T) {
t.Errorf("Received unexpected collect request")
}
metrics, _ := initialiseMetrics(getTestLogger())
metrics, _ := initialiseMetrics(log)
responseChannel <- metrics
select {
@@ -58,8 +59,9 @@ func TestCollect(t *testing.T) {
teardownTestCase := setupTestCase(false)
defer teardownTestCase()
log := getTestLogger()
exporter := newExporter("qmName")
exporter := newExporter("qmName", log)
exporter.gaugeMap["ClassName/Type1Name/Element1Name"] = createGaugeVec("Element1Name", "Element1Description", false)
for i := 1; i <= 3; i++ {
@@ -76,7 +78,7 @@ func TestCollect(t *testing.T) {
}
populateTestMetrics(i, false)
metrics, _ := initialiseMetrics(getTestLogger())
metrics, _ := initialiseMetrics(log)
updateMetrics(metrics)
responseChannel <- metrics